Skip to content

feat(SpringBoot4): bump to spring boot 4 and gradle 8.14 #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lwih wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(SpringBoot4): bump to spring boot 4 and gradle 8.14 #1123

lwih wants to merge 2 commits into from
+977 −580

Conversation

@lwih
Copy link
Collaborator

@lwih lwih commented Jan 8, 2026

No description provided.

@tristanrobert
Copy link

tristanrobert commented Jan 8, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026 •
edited
Loading

Coverage Report for frontend

Status Category Percentage Covered / Total
🔵 Lines 60.19% (🎯 40%) 2622 / 4356
🔵 Statements 58.67% (🎯 40%) 2838 / 4837
🔵 Functions 49.55% (🎯 40%) 883 / 1782
🔵 Branches 55.75% (🎯 40%) 1167 / 2093
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
frontend/src/v2/features/common/components/ui/mission-page-footer.tsx 64.7% 81.25% 33.33% 68.75% 31-34, 48
frontend/src/v2/features/common/services/use-create-action.tsx 87.5% 57.14% 72.72% 86.95% 67, 102-114
Generated in workflow #3654 for commit c9506e0 by the Vitest Coverage Report Action

lwih
lwih commented Jan 12, 2026
View reviewed changes
backend/src/main/kotlin/fr/gouv/dgampa/rapportnav/RapportNavApplication.kt
Comment on lines -33 to -48

val isSentryEnabled: String? = ctx.environment.getProperty("sentry.enabled")
val sentryDsn: String? = System.getenv("SENTRY_DSN")

if (isSentryEnabled == "true") {
Sentry.init { options ->
options.environment = System.getenv("ENV_PROFILE")
options.dsn = sentryDsn
options.proxy = SentryOptions.Proxy(
System.getenv("PROXY_HOST"),
System.getenv("PROXY_PORT"),
)
options.tracesSampleRate = 1.0
}
}

Copy link
Collaborator Author

@lwih lwih Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai viré ce code là.
Il suffit de mettre ces propriétés dans application-propertioes.yml et ca s'occupe de tout tout seul

lwih
lwih commented Jan 12, 2026
View reviewed changes
...n/fr/gouv/dgampa/rapportnav/domain/use_cases/mission/action/GetFishActionByIdAndMissionId.kt
private val getFishActionsByMissionId: GetFishActionsByMissionId,
private val attachControlsToActionControl: AttachControlsToActionControl,
private val mapper: ObjectMapper
private val mapper: JsonMapper
Copy link
Collaborator Author

@lwih lwih Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A la place d'ObjectMapper pour le JSON, Jackson3 a maintenant une classe dédiée qui est JsonMapper

@MTES-MCT MTES-MCT deleted a comment from github-actions bot Jan 12, 2026
@MTES-MCT MTES-MCT deleted a comment from github-actions bot Jan 12, 2026
@MTES-MCT MTES-MCT deleted a comment from github-actions bot Jan 12, 2026
@MTES-MCT MTES-MCT deleted a comment from github-actions bot Jan 12, 2026
@MTES-MCT MTES-MCT deleted a comment from github-actions bot Jan 12, 2026
@MTES-MCT MTES-MCT deleted a comment from github-actions bot Jan 12, 2026
@lwih lwih marked this pull request as ready for review January 12, 2026 16:05
@MTES-MCT MTES-MCT deleted a comment from github-actions bot Jan 14, 2026
@lwih lwih force-pushed the spring4 branch 2 times, most recently from eb85d34 to 27b143c Compare January 14, 2026 18:20
@MTES-MCT MTES-MCT deleted a comment from github-actions bot Jan 14, 2026
@MTES-MCT MTES-MCT deleted a comment from github-actions bot Jan 14, 2026
@MTES-MCT MTES-MCT deleted a comment from github-actions bot Jan 14, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2026

Overall Project 52.65% -0.41% ❌
Files changed 38.84% ❌

File Coverage
JacksonConfig.kt 100% 🍏
ApiKeyAuthenticationFilter.kt 98.53% 🍏
EnvActionControlEntity.kt 97.32% 🍏
EnvActionSurveillanceEntity.kt 96.3% 🍏
PatchMissionInput.kt 95.12% -4.88% 🍏
MissionEnvActionData.kt 94.18% 🍏
CreateApiKey.kt 89.53% -2.62% ❌
ApiAdminController.kt 88.24% -11.76% 🍏
MissionData.kt 87.91% 🍏
EnvActionEntity.kt 84.35% -1.02% ❌
MissionActionModel.kt 76.81% 🍏
GetEnvMissionById.kt 76.4% 🍏
APIEnvControlUnitRepository.kt 66.1% -10.17% ❌
TargetModel2.kt 63.96% 🍏
ControlModel2.kt 59.68% 🍏
APIEnvMissionRepositoryV2.kt 59.37% -2.37% ❌
UserEntity.kt 52.82% 🍏
APIEnvMissionRepository.kt 47.94% 🍏
MissionDataOutput.kt 35.41% -0.81% ❌
ApiErrorController.kt 15.22% -71.74% ❌
JacksonGeoConfig.kt 9.25% -81.5% ❌
RapportNavApplication.kt 5.36% 🍏
MissionActionDataOutput.kt 0% -0.88% ❌
GetNatinfs.kt 0% -39.22% ❌
APIEnvAdministrationRepository.kt 0% -1.66% ❌
APIEnvControlUnitResourceRepository.kt 0% -44.9% ❌
JPAUserRepository.kt 0% -3.53% ❌
APIFishActionRepository.kt 0% -9.9% ❌
UserModel.kt 0% 🍏
VersionController.kt 0% 🍏
AdministrationStubs.kt 0% 🍏
GetFishActionByIdAndMissionId.kt 0% -4.17% ❌
GetEnvActionByIdAndMissionId.kt 0% 🍏
GetNavActionByIdAndMissionId.kt 0% 🍏
JPAControlGensDeMerRepository.kt 0% -2.65% ❌
JPAControlAdministrativeRepository.kt 0% -2.65% ❌
JPAControlSecurityRepository.kt 0% -2.65% ❌
JPAControlNavigationRepository.kt 0% -2.65% ❌
GetUserFromToken.kt 0% -66.67% ❌
JPAAgentRepository.kt 0% -4.35% ❌
ActionControlModel.kt 0% -2.18% ❌
ActionFreeNoteModel.kt 0% -4.71% ❌
JPAActionControlRepository.kt 0% -7.37% ❌
JPAActionStatusRepository.kt 0% -3.57% ❌
JPAActionFreeNoteRepository.kt 0% -8.33% ❌
JPAInfractionRepository.kt 0% -7.83% ❌

@lwih lwih requested a review from xtiannyeto January 14, 2026 18:49
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

Overall Project 52.63% -0.47% ❌
Files changed 36.13% ❌

File Coverage
JacksonConfig.kt 100% 🍏
ApiKeyAuthenticationFilter.kt 98.53% 🍏
EnvActionControlEntity.kt 97.32% 🍏
EnvActionSurveillanceEntity.kt 96.3% 🍏
PatchMissionInput.kt 95.12% -4.88% 🍏
MissionEnvActionData.kt 94.18% 🍏
CreateApiKey.kt 89.53% -2.62% ❌
ApiAdminController.kt 88.24% -11.76% 🍏
MissionData.kt 87.91% 🍏
EnvActionEntity.kt 84.35% -1.02% ❌
MissionActionModel.kt 76.81% 🍏
GetEnvMissionById.kt 76.4% 🍏
APIEnvControlUnitRepository.kt 66.1% -10.17% ❌
TargetModel2.kt 63.96% 🍏
ControlModel2.kt 59.68% 🍏
APIEnvMissionRepositoryV2.kt 59.37% -2.37% ❌
UserEntity.kt 52.82% 🍏
APIEnvMissionRepository.kt 46.37% -9.39% ❌
MissionDataOutput.kt 35.41% -0.81% ❌
ApiErrorController.kt 15.22% -71.74% ❌
JacksonGeoConfig.kt 9.25% -81.5% ❌
RapportNavApplication.kt 5.36% 🍏
MissionActionDataOutput.kt 0% -0.88% ❌
GetNatinfs.kt 0% -39.22% ❌
APIEnvAdministrationRepository.kt 0% -1.66% ❌
APIEnvControlUnitResourceRepository.kt 0% -44.9% ❌
JPAUserRepository.kt 0% -3.53% ❌
APIFishActionRepository.kt 0% -9.9% ❌
UserModel.kt 0% 🍏
VersionController.kt 0% 🍏
AdministrationStubs.kt 0% 🍏
GetFishActionByIdAndMissionId.kt 0% -4.17% ❌
GetEnvActionByIdAndMissionId.kt 0% 🍏
GetNavActionByIdAndMissionId.kt 0% 🍏
JPAControlGensDeMerRepository.kt 0% -2.65% ❌
JPAControlAdministrativeRepository.kt 0% -2.65% ❌
JPAControlSecurityRepository.kt 0% -2.65% ❌
JPAControlNavigationRepository.kt 0% -2.65% ❌
GetUserFromToken.kt 0% -66.67% ❌
JPAAgentRepository.kt 0% -4.35% ❌
ActionControlModel.kt 0% -2.18% ❌
ActionFreeNoteModel.kt 0% -4.71% ❌
JPAActionControlRepository.kt 0% -7.37% ❌
JPAActionStatusRepository.kt 0% -3.57% ❌
JPAActionFreeNoteRepository.kt 0% -8.33% ❌
JPAInfractionRepository.kt 0% -7.83% ❌

@MTES-MCT MTES-MCT deleted a comment from github-actions bot Jan 15, 2026
@MTES-MCT MTES-MCT deleted a comment from github-actions bot Jan 15, 2026
@MTES-MCT MTES-MCT deleted a comment from github-actions bot Jan 15, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

Overall Project 52.67% -0.48% ❌
Files changed 35.82% ❌

File Coverage
JacksonConfig.kt 100% 🍏
ApiKeyAuthenticationFilter.kt 98.53% 🍏
EnvActionControlEntity.kt 97.32% 🍏
EnvActionSurveillanceEntity.kt 96.3% 🍏
PatchMissionInput.kt 95.12% -4.88% 🍏
MissionEnvActionData.kt 94.18% 🍏
CreateApiKey.kt 89.53% -2.62% ❌
ApiAdminController.kt 88.24% -11.76% 🍏
MissionData.kt 87.91% 🍏
EnvActionEntity.kt 84.35% -1.02% ❌
MissionActionModel.kt 76.81% 🍏
GetEnvMissionById.kt 76.4% 🍏
APIEnvControlUnitRepository.kt 66.1% -10.17% ❌
TargetModel2.kt 63.96% 🍏
ControlModel2.kt 59.68% 🍏
APIEnvMissionRepositoryV2.kt 59.37% -2.37% ❌
UserEntity.kt 52.82% 🍏
APIEnvMissionRepository.kt 45.92% -10.28% ❌
MissionDataOutput.kt 35.41% -0.81% ❌
ApiErrorController.kt 15.22% -71.74% ❌
JacksonGeoConfig.kt 9.25% -81.5% ❌
RapportNavApplication.kt 5.36% 🍏
MissionActionDataOutput.kt 0% -0.88% ❌
GetNatinfs.kt 0% -39.22% ❌
APIEnvAdministrationRepository.kt 0% -1.66% ❌
APIEnvControlUnitResourceRepository.kt 0% -44.9% ❌
JPAUserRepository.kt 0% -3.53% ❌
APIFishActionRepository.kt 0% -9.9% ❌
UserModel.kt 0% 🍏
VersionController.kt 0% 🍏
AdministrationStubs.kt 0% 🍏
GetFishActionByIdAndMissionId.kt 0% -4.17% ❌
GetEnvActionByIdAndMissionId.kt 0% 🍏
GetNavActionByIdAndMissionId.kt 0% 🍏
JPAControlGensDeMerRepository.kt 0% -2.65% ❌
JPAControlAdministrativeRepository.kt 0% -2.65% ❌
JPAControlSecurityRepository.kt 0% -2.65% ❌
JPAControlNavigationRepository.kt 0% -2.65% ❌
GetUserFromToken.kt 0% -66.67% ❌
JPAAgentRepository.kt 0% -4.35% ❌
ActionControlModel.kt 0% -2.18% ❌
ActionFreeNoteModel.kt 0% -4.71% ❌
JPAActionControlRepository.kt 0% -7.37% ❌
JPAActionStatusRepository.kt 0% -3.57% ❌
JPAActionFreeNoteRepository.kt 0% -8.33% ❌
JPAInfractionRepository.kt 0% -7.83% ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xtiannyeto xtiannyeto xtiannyeto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lwih @tristanrobert @xtiannyeto